nune/gitea
nune/gitea
0
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

Fix get reviewers' bug (#32415)

Browse source 
This PR rewrites `GetReviewer` function and move it to service layer.

Reviewers should not be watchers, so that this PR removed all watchers
from reviewers. When the repository is under an organization, the pull
request unit read permission will be checked to resolve the bug of
#32394

Fix #32394
This commit is contained in:
Lunny Xiao 2024-11-22 07:44:48 -08:00 • committed by GitHub
parent bc7d599030
commit fe49cb0243
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
12 changed files with 225 additions and 158 deletions
Download patch file Download diff file Expand all files Collapse all files

4
tests/integration/api_repo_test.go
View file

@ -718,8 +718,8 @@ func TestAPIRepoGetReviewers(t *testing.T) {
resp := MakeRequest(t, req, http.StatusOK)
var reviewers []*api.User
DecodeJSON(t, resp, &reviewers)
if assert.Len(t, reviewers, 3) {
assert.ElementsMatch(t, []int64{1, 4, 11}, []int64{reviewers[0].ID, reviewers[1].ID, reviewers[2].ID})
if assert.Len(t, reviewers, 1) {
assert.ElementsMatch(t, []int64{2}, []int64{reviewers[0].ID})
}
}