Improve natural sort (#29611)

Hugely simplify the code, and add more tests (only new approach could
pass)
This commit is contained in:
wxiaoguang 2024-03-05 23:13:35 +08:00 committed by GitHub
parent 3f3335ae51
commit ebff37ae09
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 12 additions and 78 deletions

View file

@ -11,7 +11,7 @@ import (
func TestNaturalSortLess(t *testing.T) {
test := func(s1, s2 string, less bool) {
assert.Equal(t, less, NaturalSortLess(s1, s2))
assert.Equal(t, less, NaturalSortLess(s1, s2), "s1=%q, s2=%q", s1, s2)
}
test("v1.20.0", "v1.2.0", false)
test("v1.20.0", "v1.29.0", true)
@ -20,4 +20,11 @@ func TestNaturalSortLess(t *testing.T) {
test("a-1-a", "a-1-b", true)
test("2", "12", true)
test("a", "ab", true)
test("A", "b", true)
test("a", "B", true)
test("cafe", "café", true)
test("café", "cafe", false)
test("caff", "café", false)
}