Always use HTML attributes for avatar size (#31509)

Many avatars were rendered in HTML with certain width/height but then
resized again in CSS. This was pointless so I removed all these cases
and made the HTML size match the previous render size.

Also did a few CSS cleanups in the tribute rendering:

<img width="648" alt="image"
src="cb2fafb3-5e20-46e9-814f-07df20038beb">
This commit is contained in:
silverwind 2024-06-28 23:29:15 +02:00 committed by GitHub
parent 08579d6cbb
commit e82f3caa6b
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
10 changed files with 11 additions and 59 deletions

View file

@ -123,12 +123,6 @@
padding-bottom: 1px;
}
#git-graph-container #rev-list .author img.ui.avatar {
width: auto;
height: 18px;
max-width: none;
}
#git-graph-container #graph-raw-list {
margin: 0;
}

View file

@ -17,7 +17,6 @@
.tribute-container li span.fullname {
font-weight: var(--font-weight-normal);
font-size: 0.8rem;
margin-left: 3px;
}
.tribute-container li.highlight,
@ -29,14 +28,5 @@
.tribute-item {
display: flex;
align-items: center;
}
.tribute-item .emoji,
.tribute-item img[src*="/avatar/"] {
margin-right: 0.5rem;
}
.tribute-container img {
width: 1.5rem !important;
height: 1.5rem !important;
gap: 6px;
}

View file

@ -50,10 +50,6 @@
background: none;
}
.ui.comments .comment .avatar {
width: 30px;
}
.ui.comments .comment > .content {
display: flex;
flex-direction: column;

View file

@ -127,8 +127,6 @@
}
.page-content.organization .members .ui.avatar {
width: 48px;
height: 48px;
margin-right: 5px;
margin-bottom: 5px;
}

View file

@ -460,14 +460,12 @@ td .commit-summary {
}
.repository.file.editor .commit-form-wrapper {
padding-left: 64px;
padding-left: 48px;
}
.repository.file.editor .commit-form-wrapper .commit-avatar {
float: left;
margin-left: -64px;
width: 3em;
height: auto;
margin-left: -48px;
}
.repository.file.editor .commit-form-wrapper .commit-form {
@ -535,10 +533,6 @@ td .commit-summary {
min-width: 100px;
}
#new-issue .comment .avatar {
width: 3em;
}
.repository.new.issue .comment.form .content::before,
.repository.new.issue .comment.form .content::after {
right: 100%;
@ -1216,16 +1210,6 @@ td .commit-summary {
border: 1px solid var(--color-light-border);
}
.repository #commits-table td.sha .sha.label .ui.signature.avatar,
.repository #repo-files-table .sha.label .ui.signature.avatar,
.repository #repo-file-commit-box .sha.label .ui.signature.avatar,
.repository #rev-list .sha.label .ui.signature.avatar,
.repository .timeline-item.commits-list .singular-commit .sha.label .ui.signature.avatar {
height: 16px;
margin-bottom: 0;
width: 16px;
}
.repository #commits-table td.sha .sha.label .detail.icon,
.repository #repo-files-table .sha.label .detail.icon,
.repository #repo-file-commit-box .sha.label .detail.icon,
@ -1242,14 +1226,6 @@ td .commit-summary {
border-bottom-left-radius: 0;
}
.repository #commits-table td.sha .sha.label .detail.icon img,
.repository #repo-files-table .sha.label .detail.icon img,
.repository #repo-file-commit-box .sha.label .detail.icon img,
.repository #rev-list .sha.label .detail.icon img,
.repository .timeline-item.commits-list .singular-commit .sha.label .detail.icon img {
margin-right: 0;
}
.repository #commits-table td.sha .sha.label .detail.icon .svg,
.repository #repo-files-table .sha.label .detail.icon .svg,
.repository #repo-file-commit-box .sha.label .detail.icon .svg,
@ -1931,8 +1907,6 @@ td .commit-summary {
}
.user-cards .list .item .avatar {
width: 48px;
height: 48px;
float: left;
display: block;
margin-right: 10px;