backport(1.15): make ParsePatch more robust (#17580)

- Backport of https://github.com/go-gitea/gitea/pull/17573
This commit is contained in:
Gusted 2021-11-08 04:28:16 +01:00 committed by GitHub
parent 20ae184967
commit b661bbaed7
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 29 additions and 1 deletions

View file

@ -539,3 +539,22 @@ func TestDiffToHTML_14231(t *testing.T) {
assertEqual(t, expected, output)
}
func TestNoCrashes(t *testing.T) {
type testcase struct {
gitdiff string
}
tests := []testcase{
{
gitdiff: "diff --git \n--- a\t\n",
},
{
gitdiff: "diff --git \"0\n",
},
}
for _, testcase := range tests {
// It shouldn't crash, so don't care about the output.
ParsePatch(setting.Git.MaxGitDiffLines, setting.Git.MaxGitDiffLineCharacters, setting.Git.MaxGitDiffFiles, strings.NewReader(testcase.gitdiff))
}
}