nune/gitea
nune/gitea
0
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

Caller should check the ResponseExtra.HasError() first to see whether the request fails (#28796)

Browse source 
`resp != nil` doesn't mean the request really succeeded. Add a comment
for requestJSONResp to clarify the behavior.
This commit is contained in:
wxiaoguang 2024-01-15 19:15:31 +08:00 • committed by GitHub
parent 637451a45e
commit b0e6c25535
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 4 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

2
modules/private/actions.go
View file

@ -22,7 +22,7 @@ func GenerateActionsRunnerToken(ctx context.Context, scope string) (string, Resp
})
resp, extra := requestJSONResp(req, &responseText{})
if resp == nil {
if extra.HasError() {
return "", extra
}
return resp.Text, extra