Disallow merge when required checked are missing (#29143) (#29268)

backport #29143 Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2024-02-19 21:48:17 +01:00 · 2024-02-19 21:48:17 +01:00 · 78f41e4fc4
commit 78f41e4fc4
parent c01b266d86
3 changed files with 47 additions and 2 deletions
--- a/services/pull/commit_status.go
+++ b/services/pull/commit_status.go
@ -50,6 +50,10 @@ func MergeRequiredContextsCommitStatus(commitStatuses []*git_model.CommitStatus,
 		}
 	}

+	if matchedCount != len(requiredContexts) {
+		return structs.CommitStatusPending
+	}
+
 	if matchedCount == 0 {
 		status := git_model.CalcCommitStatus(commitStatuses)
 		if status != nil {