Refactor RepoRefByType (#32413)
1. clarify the "filepath" could(should) contain "{ref}" 2. remove unclear RepoRefLegacy and RepoRefAny, use RepoRefUnknown to guess 3. by the way, avoid using AppURL
This commit is contained in:
parent
4a469c8e1b
commit
61c35590c7
7 changed files with 100 additions and 109 deletions
|
@ -49,18 +49,18 @@ func TestLinksNoLogin(t *testing.T) {
|
|||
func TestRedirectsNoLogin(t *testing.T) {
|
||||
defer tests.PrepareTestEnv(t)()
|
||||
|
||||
redirects := map[string]string{
|
||||
"/user2/repo1/commits/master": "/user2/repo1/commits/branch/master",
|
||||
"/user2/repo1/src/master": "/user2/repo1/src/branch/master",
|
||||
"/user2/repo1/src/master/file.txt": "/user2/repo1/src/branch/master/file.txt",
|
||||
"/user2/repo1/src/master/directory/file.txt": "/user2/repo1/src/branch/master/directory/file.txt",
|
||||
"/user/avatar/Ghost/-1": "/assets/img/avatar_default.png",
|
||||
"/api/v1/swagger": "/api/swagger",
|
||||
redirects := []struct{ from, to string }{
|
||||
{"/user2/repo1/commits/master", "/user2/repo1/commits/branch/master"},
|
||||
{"/user2/repo1/src/master", "/user2/repo1/src/branch/master"},
|
||||
{"/user2/repo1/src/master/file.txt", "/user2/repo1/src/branch/master/file.txt"},
|
||||
{"/user2/repo1/src/master/directory/file.txt", "/user2/repo1/src/branch/master/directory/file.txt"},
|
||||
{"/user/avatar/Ghost/-1", "/assets/img/avatar_default.png"},
|
||||
{"/api/v1/swagger", "/api/swagger"},
|
||||
}
|
||||
for link, redirectLink := range redirects {
|
||||
req := NewRequest(t, "GET", link)
|
||||
for _, c := range redirects {
|
||||
req := NewRequest(t, "GET", c.from)
|
||||
resp := MakeRequest(t, req, http.StatusSeeOther)
|
||||
assert.EqualValues(t, path.Join(setting.AppSubURL, redirectLink), test.RedirectURL(resp))
|
||||
assert.EqualValues(t, path.Join(setting.AppSubURL, c.to), test.RedirectURL(resp))
|
||||
}
|
||||
}
|
||||
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue