nune/gitea
nune/gitea
0
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

Fix duplicate dropdown dividers (#32760)

Browse source 
Fix #27466

The problem is that any item in the menu could be hidden, pure CSS won't
work, and dropdown's builtin "hideDividers" doesn't work with our "scope
dividers". The newly introduced "archived" label makes the dividers
regression more.
This commit is contained in:
wxiaoguang 2024-12-09 15:54:59 +08:00 • committed by GitHub
parent 2d13eafd69
commit 5675efb3e0
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
10 changed files with 179 additions and 42 deletions
Download patch file Download diff file Expand all files Collapse all files

8
modules/templates/helper.go
View file

@ -294,9 +294,7 @@ func timeEstimateString(timeSec any) string {
return util.TimeEstimateString(v)
}
type QueryString string
func queryBuild(a ...any) QueryString {
func queryBuild(a ...any) template.URL {
var s string
if len(a)%2 == 1 {
if v, ok := a[0].(string); ok {
@ -304,7 +302,7 @@ func queryBuild(a ...any) QueryString {
panic("queryBuild: invalid argument")
}
s = v
} else if v, ok := a[0].(QueryString); ok {
} else if v, ok := a[0].(template.URL); ok {
s = string(v)
} else {
panic("queryBuild: invalid argument")
@ -356,7 +354,7 @@ func queryBuild(a ...any) QueryString {
if s != "" && s != "&" && s[len(s)-1] == '&' {
s = s[:len(s)-1]
}
return QueryString(s)
return template.URL(s)
}
func panicIfDevOrTesting() {