Refactor names (#31405)
This PR only does "renaming": * `Route` should be `Router` (and chi router is also called "router") * `Params` should be `PathParam` (to distingush it from URL query param, and to match `FormString`) * Use lower case for private functions to avoid exposing or abusing
This commit is contained in:
parent
17baf1af10
commit
43c7a2e7b1
177 changed files with 837 additions and 837 deletions
|
@ -50,7 +50,7 @@ const (
|
|||
// getDashboardContextUser finds out which context user dashboard is being viewed as .
|
||||
func getDashboardContextUser(ctx *context.Context) *user_model.User {
|
||||
ctxUser := ctx.Doer
|
||||
orgName := ctx.Params(":org")
|
||||
orgName := ctx.PathParam(":org")
|
||||
if len(orgName) > 0 {
|
||||
ctxUser = ctx.Org.Organization.AsUser()
|
||||
ctx.Data["Teams"] = ctx.Org.Teams
|
||||
|
@ -714,9 +714,9 @@ func ShowGPGKeys(ctx *context.Context) {
|
|||
func UsernameSubRoute(ctx *context.Context) {
|
||||
// WORKAROUND to support usernames with "." in it
|
||||
// https://github.com/go-chi/chi/issues/781
|
||||
username := ctx.Params("username")
|
||||
username := ctx.PathParam("username")
|
||||
reloadParam := func(suffix string) (success bool) {
|
||||
ctx.SetParams("username", strings.TrimSuffix(username, suffix))
|
||||
ctx.SetPathParam("username", strings.TrimSuffix(username, suffix))
|
||||
context.UserAssignmentWeb()(ctx)
|
||||
if ctx.Written() {
|
||||
return false
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue