Clarify path param naming (#32969)
In history (from some legacy frameworks), both `:name` and `name` are supported as path path name, `:name` is an alias to `name`. To make code consistent, now we should only use `name` but not `:name`. Also added panic check in related functions to make sure the name won't be abused in case some downstreams still use them.
This commit is contained in:
parent
b8b690feb9
commit
2a828e2798
102 changed files with 461 additions and 429 deletions
|
@ -17,8 +17,8 @@ func TestCheckProjectColumnChangePermissions(t *testing.T) {
|
|||
ctx, _ := contexttest.MockContext(t, "user2/repo1/projects/1/2")
|
||||
contexttest.LoadUser(t, ctx, 2)
|
||||
contexttest.LoadRepo(t, ctx, 1)
|
||||
ctx.SetPathParam(":id", "1")
|
||||
ctx.SetPathParam(":columnID", "2")
|
||||
ctx.SetPathParam("id", "1")
|
||||
ctx.SetPathParam("columnID", "2")
|
||||
|
||||
project, column := checkProjectColumnChangePermissions(ctx)
|
||||
assert.NotNil(t, project)
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue