Clarify path param naming (#32969)
In history (from some legacy frameworks), both `:name` and `name` are supported as path path name, `:name` is an alias to `name`. To make code consistent, now we should only use `name` but not `:name`. Also added panic check in related functions to make sure the name won't be abused in case some downstreams still use them.
This commit is contained in:
parent
b8b690feb9
commit
2a828e2798
102 changed files with 461 additions and 429 deletions
|
@ -223,7 +223,7 @@ func GetPushMirrorByName(ctx *context.APIContext) {
|
|||
return
|
||||
}
|
||||
|
||||
mirrorName := ctx.PathParam(":name")
|
||||
mirrorName := ctx.PathParam("name")
|
||||
// Get push mirror of a specific repo by remoteName
|
||||
pushMirror, exist, err := db.Get[repo_model.PushMirror](ctx, repo_model.PushMirrorOptions{
|
||||
RepoID: ctx.Repo.Repository.ID,
|
||||
|
@ -324,7 +324,7 @@ func DeletePushMirrorByRemoteName(ctx *context.APIContext) {
|
|||
return
|
||||
}
|
||||
|
||||
remoteName := ctx.PathParam(":name")
|
||||
remoteName := ctx.PathParam("name")
|
||||
// Delete push mirror on repo by name.
|
||||
err := repo_model.DeletePushMirrors(ctx, repo_model.PushMirrorOptions{RepoID: ctx.Repo.Repository.ID, RemoteName: remoteName})
|
||||
if err != nil {
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue