Only allow admins to rename default/protected branches (#33276)
Currently, anyone with write permissions to a repo are able to rename default or protected branches. This change follows [GitHub's](https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/managing-branches-in-your-repository/renaming-a-branch) design by only allowing repo/site admins to change these branches. However, it also follows are current design for protected branches and only allows admins to modify branch names == branch protection rule names. Glob-based rules cannot be renamed by anyone (as was already the case, but we now catch `ErrBranchIsProtected` which we previously did not catch, throwing a 500).
This commit is contained in:
parent
4b21a6c792
commit
2483a93fbc
7 changed files with 90 additions and 10 deletions
|
@ -735,5 +735,5 @@ func TestAPIRepoGetAssignees(t *testing.T) {
|
|||
resp := MakeRequest(t, req, http.StatusOK)
|
||||
var assignees []*api.User
|
||||
DecodeJSON(t, resp, &assignees)
|
||||
assert.Len(t, assignees, 1)
|
||||
assert.Len(t, assignees, 2)
|
||||
}
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue