[Bug]: Race condition on commands #31
Labels
No labels
Bug
Confirmed
Crash
Documentation
Duplicate
Enhancement
High Priority
Invalid
Mod compatibility
Needs triage
Stale
Won't Fix
No milestone
No project
No assignees
2 participants
Total time spent: 1 hour 6 minutes
Due date
LunaFox
1 hour 6 minutes
No due date set.
Dependencies
No dependencies set.
Reference
LunaFox/AutoWhitelist#31
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Hey i got this error on the Discord Bot, it has not responsed in Discord.
Could you also add an option where the bot could write like the chanel id?
And this one
Does the bot have permission to send messages on the given channel? (if ephemeral messages are off)
Could you also provide the output of running
/autowhitelist dump statsin the server console@LunaFox yes, the bot could write,
I had found an information,
The bot response if i‘m on the server, he sees that i‘m online and give informations to me,
But if i‘m not on the server, the bot could not response anymore.
Look like an issue on uuid fetchin with offline players
I think you shoul look on this importy, to search for offline players what are not trying to connect on the server before. Or if the player is not given an NULL check
:)
import com.mojang.authlib.yggdrasil.YggdrasilAuthenticationService;
import com.mojang.authlib.GameProfile;
import java.util.UUID;
Please provide the output of
/autowhitelist dump statsI'll need it's output to know some important information for debugging
When the error happens, does the command timeout shortly after you execute it or does it show something like "Bot is thinking..."?
It shows, the Bot is thinking, after time it get an timeout on server side.
Only if i‘m not online, if i‘m on the server the bit is responsing really fast.
This seems likely a race condition, I will setup a local environment with increased delay to discord to test the issue and work on a fix
Error on Discord bot, no response on Channelto [Bug]: Race condition on commandsoh god i forgot to release the fix, I fixed it and forgot to press release, i'm stupid
Version 1.2.3 should properly handle the messages on a race condition now
Hey, no issue :)
but
have you updated to the new version?
from my tests it has worked without issues
Fortunately, this should only affect the messages, and registering should still work, but this is still an important issue
You could see -> autowhitelist-1.2.3+1.21.jar yes i had updated.
i had thinked a little bit about the issue,
think you should track active interaction, and check it is nullable, before interactions, you had added buttons, but with the timeout it runs in an null... after expired interaction, you could clean up the listener for the interactions...
https://kitsunes.dev/LunaFox/AutoWhitelist/src/branch/main/src/main/java/com/awakenedredstone/autowhitelist/discord/command/InfoCommand.java
like an event listener. bruh, i understand a little bit, but have no informations about discord. but we get an null, we need to track from where it come in the info command. and then fix the nullable interaction
sorry for my bad english, hope you understand what i mean
the error that is showing is caused by the mod silently failing to modify the initial message
I have to patch the silent failure, as that is the main issue, since fixing the NullPointerException won't fix the message not showing up
@LunaFox wrote in #31 (comment):
Okey, :) i‘m only trying to understand a little bit the code, how he is writen.
Thanks for you work here :)