From b408f66f9de79846e328c2c9689c913d03311b7f Mon Sep 17 00:00:00 2001 From: CenTdemeern1 Date: Wed, 12 Feb 2025 21:59:35 +0100 Subject: [PATCH] Use hidden properly everywhere --- static/confirm_instance_details.mts | 4 ++-- static/crossroad.mts | 6 ++---- static/image.mts | 2 +- 3 files changed, 5 insertions(+), 7 deletions(-) diff --git a/static/confirm_instance_details.mts b/static/confirm_instance_details.mts index 4dd5bb0..f6619ab 100644 --- a/static/confirm_instance_details.mts +++ b/static/confirm_instance_details.mts @@ -146,9 +146,9 @@ export class InstanceDetailsDialog extends FormDialog { #handleListEmpty() { if (!this.defaultsList) return; if (this.defaultsList.list.children.length == 1) { - this.defaultsList.noDefaultsOption.removeAttribute("hidden"); + this.defaultsList.noDefaultsOption.hidden = false; } else { - this.defaultsList.noDefaultsOption.setAttribute("hidden", ""); + this.defaultsList.noDefaultsOption.hidden = true; } } diff --git a/static/crossroad.mts b/static/crossroad.mts index 234d215..299cc27 100644 --- a/static/crossroad.mts +++ b/static/crossroad.mts @@ -46,10 +46,8 @@ redirectAlwaysButton.addEventListener("click", e => { }); function updateNoInstanceHint() { - findParagraphOrFail(document.body, "#no-instance").style.display = - storageManager.storage.instances.length > 0 - ? "none" - : ""; + findParagraphOrFail(document.body, "#no-instance").hidden = + storageManager.storage.instances.length > 0; } function createInstanceSelectOptions() { diff --git a/static/image.mts b/static/image.mts index e85e407..04a550a 100644 --- a/static/image.mts +++ b/static/image.mts @@ -2,7 +2,7 @@ export function resize(image: HTMLImageElement, width: number = 16, height: numb const canvas = document.createElement('canvas'); canvas.width = width; canvas.height = height; - canvas.style.display = "none"; + canvas.hidden = true; document.body.appendChild(canvas); const ctx = canvas.getContext("2d"); if (ctx === null) throw Error("Resize failed");